starknet-io / starkgate-frontend

Bridge interface allows users to transfer ERC20 tokens from Ethereum to StarkNet and vice versa.
https://starkgate.starknet.io
Apache License 2.0
148 stars 84 forks source link

fix(3141693842): amount input isn’t disabled when user isn’t logged in #291

Closed galuzan-starkware closed 2 years ago

galuzan-starkware commented 2 years ago

Description of the Changes

Solves #3141693842


Checklist


This change is Reviewable

netlify[bot] commented 2 years ago

Deploy Preview for integration-starkgate ready!

Name Link
Latest commit a53f916633d7590ae28824a3fb8b16dc7df26c41
Latest deploy log https://app.netlify.com/sites/integration-starkgate/deploys/630c649fb8a13b0009410ba6
Deploy Preview https://deploy-preview-291--integration-starkgate.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Deploy Preview for goerli-starkgate ready!

Name Link
Latest commit a53f916633d7590ae28824a3fb8b16dc7df26c41
Latest deploy log https://app.netlify.com/sites/goerli-starkgate/deploys/630c649fde6fed0008906083
Deploy Preview https://deploy-preview-291--goerli-starkgate.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

galuzan-starkware commented 2 years ago

@yairans-starkware @dan-ziv Guy's response: Hi Gal, I meant that you can click on the input with the cursor and the cursor can blink there (to be honest It’s not critical, you can also disable the blink inside and don’t let anyone get there till the wallet connects) but once I type my keyboard nothing should happen, right now if I click the keyboard I can insert my input.

I think it’s better to disable it, as I did.

So if you think the same, please approve

dan-ziv commented 2 years ago

:tada: This PR is included in version 1.9.0-dev.6 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

dan-ziv commented 1 year ago

:tada: This PR is included in version 1.9.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

dan-ziv commented 1 year ago

:tada: This PR is included in version 1.9.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: