fix: Wallet L1 & L2 is connected auto connect

starknet-io / starkgate-frontend

Bridge interface allows users to transfer ERC20 tokens from Ethereum to StarkNet and vice versa.

https://starkgate.starknet.io

Apache License 2.0

148 stars 84 forks source link

fix: Wallet L1 & L2 is connected auto connect #324

Closed nlyrthiia closed 1 year ago

nlyrthiia commented 1 year ago

Description of the Changes

Please add a detailed description of the change, whether it's an enhancement or a bugfix. If the PR is related to an open issue please link to it.

Solves #INSERT_MONDAY_ID_HERE

If the user is already connected to the wallet, it will be automatically connected when entering the page.Fewer clicks, better user experience.

origin:

origin.webm

change:

change.webm

walletConfig add 'starknetWalletOptions' props, change getStarknetWallet option

Checklist

[x] Manually tests of the main Application flows are done and passed.
[ ] New unit / functional tests have been added (whenever applicable).
[ ] Docs have been updated (whenever relevant).
[x] PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

This change is

l-henri commented 1 year ago

Hello! Thank you for this PR. We asked the team if this PR could be included, and here is their answer:

It's not a bug, and it's not a small fix either.
We're working now internally to add this feature (there are some challenges since not all the wallets act the same).
This will be available in the next release (v1.11 - in about 2 weeks).

So, unfortunately we won't be able to merge this PR for now. Thank you for your work on this, please don't hesitate and send others in the future!

nlyrthiia commented 1 year ago

@l-henri Ok, thank you. Maybe I should try to contact them first, which can help me check my project proposal and avoid repetitive or useless work. If there is anything I can do to help, please feel free to contact me ~ Thank you

dan-ziv commented 1 year ago

Hey @nlyrthiia! Thank you very much for your recent contributions; we appreciate it.

This specific feature is, unfortunately, already in development. We wanted to implement it more core-level since we're going to support more L1 wallets soon, and for this, we want something more robust (for example, relay on cookies to determine your last connected wallet, add this logic as part of the of wallet hook and not as part of the button component, and more).

If you want some ideas on some backlog features that are waiting in the queue, feel free to contact me at danz@starkware.co.

Thanks again!