starknet-io / starkgate-frontend

Bridge interface allows users to transfer ERC20 tokens from Ethereum to StarkNet and vice versa.
https://starkgate.starknet.io
Apache License 2.0
148 stars 84 forks source link

feat: Select token supports uppercase search & Support symbol search #325

Open nlyrthiia opened 1 year ago

nlyrthiia commented 1 year ago

Description of the Changes

When entering 'ETH', 'usdc' in the search box, the correct results cannot be obtained. After the modification, the uppercase can also be used to search for the correct results and the search for the symbol field has been increased. There is also a discussion about whether spaces should be included in the search. Referring to uniswap, both upper and lower case can be searched normally, spaces are not in the search field, and only symbols are retrieved.

change:

change.webm

origin:

origin.webm

uniswap:

uniswap.webm


Checklist


This change is Reviewable

dan-ziv commented 1 year ago

Hey @nlyrthiia, thanks for this PR - good idea :-) Left some small comment, after this we can merge.

nlyrthiia commented 1 year ago

@dan-ziv ok gratitude for the suggestion, the code has been modified