Open nlyrthiia opened 1 year ago
Hey @nlyrthiia - nice catch! Since Edge is chromium-based, all Chrome-supported extensions should work either on Edge, that's great.
We are changing the wallet abstraction handlers from classes to hooks, so I don't want to add this support to code that will be removed in the next version.
I suggest waiting with this PR to v1.11.0 and then adding it again with the new implementation. WDYT?
@dan-ziv Ok, I think we can wait until after v1.11.0 to implement edge support.
And I found some problems in the process of using Starkgate. Now I am also participating in the ecological construction related to Starknet. I am looking for something I can do.
If I have the opportunity, I hope to participate in the latest Starkgate-frontend project. Get To the latest progress, so that I can be more precise about some PRs of Starkgate-frontend and avoid doing some work that will conflict with your existing progress.
Description of the Changes
Wallet connection supports edge browser.
This is the value of Desktop Browser Market Share worldwide OCT2021-OCT2022 link:
It can be seen that the share of Edge is still good. The native plug-in of Edge already supports Metamask, and Edge is fully compatible with other Chrome plug-ins, and can be used normally during the development process.
origin:
change:
Not Installed:
change_not_installed.webm
Installed:
change_installedwebm
Checklist
<type>[optional scope]: <description>
, e.g:fix: prevent racing of requests
This change is