starknet-io / starknet-docs

The repo for Starknet's developer documentation. Includes contribution guidelines and the Starknet documentation supplementary style guide
https://docs.starknet.io/
112 stars 159 forks source link

fix: Fix example in emit_events #1169

Closed stoobie closed 4 months ago

stoobie commented 4 months ago

Description of the Changes

This PR fixes #1124.

  1. The syscall emit_event example is incorrect, and the problem noted in num 2 also applies here.

  2. https://docs.starknet.io/documentation/architecture_and_concepts/Smart_Contracts/starknet-events/

    The above code emits an event with two keys, the strings “status” and “deposit”

    The code shown actually uses “key” and “deposit” as keys

PR Preview URL

Events emit_event

Check List


This change is Reviewable

github-actions[bot] commented 4 months ago

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1169/documentation/ .

github-actions[bot] commented 4 months ago

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1169/documentation/ .