starknet-io / starknet-docs

The repo for Starknet's developer documentation. Includes contribution guidelines and the Starknet documentation supplementary style guide
https://docs.starknet.io/
130 stars 181 forks source link

fix: Upload to prod server not working #1184

Closed stoobie closed 6 months ago

stoobie commented 6 months ago

Description of the Changes

There is a step in push.yml that is not succeeding. It seems to just create a version tag. Upon creating the version tag, the tag.yml workflow runs. The last step in this workflow, after creating a Release, is to upload the site to the prod server.

Given that we wanted to remove the tag and release workflows from this repo anyway, I moved the upload step directly to the push.yml workflow, and skip the step to create a new version tag and new release.

PR Preview URL

After you push a commit to this PR, a preview is built and a URL to the root of the preview appears in the comment feed.

Paste here the specific URL(s) of the content that this PR addresses.

Check List


This change is Reviewable

github-actions[bot] commented 6 months ago

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1184/documentation/ .