search

starknet-io / starknet-docs

The repo for Starknet's developer documentation. Includes contribution guidelines and the Starknet documentation supplementary style guide
https://docs.starknet.io/
110 stars 157 forks source link

Wrong field in v1 (deprecated) hash calculation documentation #1284

Closed thiagodeev closed 1 day ago

thiagodeev commented 4 weeks ago

One of these two lines must be wrong. It contains "1" but all other transactions contain "0", also the description says "0". It's confusing. https://github.com/starknet-io/starknet-docs/blob/72714abc276e048ba5779697afbebba9691e8430/components/Starknet/modules/architecture_and_concepts/pages/Network_Architecture/transactions.adoc?plain=1#L408

https://github.com/starknet-io/starknet-docs/blob/72714abc276e048ba5779697afbebba9691e8430/components/Starknet/modules/architecture_and_concepts/pages/Network_Architecture/transactions.adoc?plain=1#L419

Benjtalkshow commented 2 weeks ago

Hello, I can help in summarizing the transaction types and hash calculations. I have a clear understanding of the DECLARE, INVOKE, and DEPLOY_ACCOUNT transactions, including their versions and hash calculation methods. Can you assign this to me?

stoobie commented 5 days ago

@Benjtalkshow This issue is just a simple fix. Would you like to do it? If so, feel free.

You're always welcome to open a PR if you feel that something could be explained better than it is, but this issue is very specific in its scope.

Benjtalkshow commented 5 days ago

@Benjtalkshow This issue is just a simple fix. Would you like to do it? If so, feel free.

You're always welcome to open a PR if you feel that something could be explained better than it is, but this issue is very specific in its scope.

@stoobie I will do it.

stoobie commented 5 days ago

@Benjtalkshow It's yours. The "1" in line 408 should be "0".