Open PhilippeR26 opened 5 months ago
@PhilippeR26 I'll like to work on this
Hello, I think it's already handled by core team (@ivpavici )
@tabaktoni
I have a strange error when using WalletAccount.deployAccount()
:
Error: Expected valid bigint: 0 < bigint < curve.n
I think that you should override deployAccount
method, using UDC.
Following the last commits of the Wallet API, 2 things have to be implemented :
[!WARNING] Currently not open to contributors.
@PhilippeR26 can we close this?
If you consider that all identified problems are solved, or are minor, or will be solved later, you can close. Personally, I think that @tabaktoni should dig a little in these subjects.
Context
I have ended the tests of
WalletAccount
. I have some comments :WalletAccount
class, but as there is no destructor in Typescript, what are the consequences for the DAPP and for the wallet to create / get out of scope many timesWalletAccount
instances?Directly with the swo :
About automatic change of account, the re-initialization of cairoVersion is missing here https://github.com/starknet-io/starknet.js/blob/4b839432e16c61e270e140dec9399c1f09a7d38b/src/wallet/account.ts#L55. About automatic change of chain, the change of this.chainId without changing the nodeurl is generating a complete mess in the DAPP. I think that if the DAPP accepts to change of chain, it has to propose a Rpc provider for each chain accepted. So, in this spirit, it will be the responsibility of the DAPP to convert a new chainId to a new Rpc provider. I think it will be important in the case of layer 3. So, we could delete setChainId, and replace it by something accepting the RpcProviderOptions as input.
Also one little thing, about the access to the frontend provider : if the DAPP wants to do something with the provider in use in the Wallet Account, it needs :
Normally,
channel
should be hidden to the DAPP devs. Couldn't we have something like :Desktop (please complete the following information):
Additional context Add any other context about the problem here.