search

starknet-io / starknet.js

JavaScript library for StarkNet
https://www.starknetjs.com
MIT License
1.23k stars 758 forks source link

getSyncingStats test fails when RPC returns false #1248

Open wojciechos opened 1 month ago

wojciechos commented 1 month ago

Describe the bug The getSyncingStats test fails when the RPC returns false. The test expects an object matching the SyncingStatus schema, but doesn't handle the case where false is returned, which is a valid response.

To Reproduce

  1. Run the RPC provider tests using a synced Juno node(then result should be false). E.g: TEST_RPC_URL=https://free-rpc.nethermind.io/sepolia-juno npm run test -- -t getSyncingStats

  2. Observe the failure

Expected behavior Test should pass when starknet_syncing results is false

Desktop (please complete the following information):

od-hunter commented 1 month ago

Hi @wojciechos , is this open for contribution?