search

starknet-io / starknet.js

JavaScript library for StarkNet
https://www.starknetjs.com
MIT License
1.21k stars 739 forks source link

casing: `Starknet` instead of `StarkNet` #705

Closed pscott closed 10 months ago

pscott commented 1 year ago

Is your feature request related to a problem? Please describe. The official casing for Starknet is not StarkNet anymore, but Starknet. However, some occurrences of StarkNet can still be found, most notably in the TypeHash function: https://github.com/0xs34n/starknet.js/blob/384db9f3bfaf066dea43f60e49f255c9a4a28b63/src/utils/typedData.ts#L255-L256

Describe the solution you'd like Replace every occurence of StarkNet with Starknet

Describe alternatives you've considered Keep StarkNet and dismiss this issue. I think it's still early enough to change to Starknet though.

Additional notes This introduces a big breaking change (:

0xdorifto commented 1 year ago

Hey! Can this issue be assigned to me?

tabaktoni commented 1 year ago

@0xdorifto Yes feel free to take it

0xdorifto commented 1 year ago

@tabaktoni thanks! I'll start working on it now.

pscott commented 1 year ago

@0xdorifto Yes feel free to take it

should we discuss if it's worth introducing the breaking change?

PhilippeR26 commented 1 year ago

Not sure it's still early enough to change. Should be first validated by ArgentX, Braavos, ...

0xdorifto commented 1 year ago

It's up here if you guys want to check it out ^

ivpavici commented 1 year ago

@janek26 @dhruvkelawala @yoga-braavos can you please give your input about this? 🙏

ivpavici commented 10 months ago

Will probably be able to close this after this one is closed https://github.com/starknet-io/get-starknet/pull/194

PhilippeR26 commented 10 months ago

Will at the end be defined by this snip : https://community.starknet.io/t/snip-off-chain-signatures-a-la-eip712/98029#abstract-1

tabaktoni commented 10 months ago

Resolved in favor of the snip, for further progress push change's on the snip