starknet-io / types-rs

🐺 Starknet Rust types 🦀

MIT License

63 stars 37 forks source link

use `is_zero` for Felt #67

Open tcoratger opened 4 months ago

tcoratger commented 4 months ago

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

Bugfix
Feature
Code style update (formatting, renaming)
Refactoring (no functional changes, no API changes)
Build-related changes
Documentation content changes
Testing
Other (please describe):

What is the current behavior?

Resolves: #NA

What is the new behavior?

use is_zero for Felt instead of == Felt::ZERO

Does this introduce a breaking change?

No

Other information

0xLucqs commented 3 months ago

It's just a slight readability imporvement and managing the features will just make it unreadable so i suggest we keep it like this ?