Closed xJonathanLEI closed 5 months ago
Please add the labels corresponding to the type of changes your PR introduces:
Hex formatting of Felt ignores alternate and zero padding options.
Felt
alternate
Hex formatting respects these options.
Technically, yes. This fix adds a requirement of alloc to the implementation of LowerHex. In reality though this will likely not affect anyone.
alloc
LowerHex
This is blocking https://github.com/xJonathanLEI/starknet-rs/pull/562.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Hex formatting of
Felt
ignoresalternate
and zero padding options.What is the new behavior?
Hex formatting respects these options.
Does this introduce a breaking change?
Technically, yes. This fix adds a requirement of
alloc
to the implementation ofLowerHex
. In reality though this will likely not affect anyone.Other information
This is blocking https://github.com/xJonathanLEI/starknet-rs/pull/562.