starknet-io / types-rs

🐺 Starknet Rust types 🦀
MIT License
66 stars 41 forks source link

Fix FeltVisitor expecting message #82

Open FabijanC opened 4 months ago

FabijanC commented 4 months ago

Pull Request type

What is the current behavior?

Wrong message used in the expecting method of FeltVisitor, not following the documentation:

The message should complete the sentence "This Visitor expects to receive ...", for example the message could be "an integer between 0 and 64". The message should not be capitalized and should not end with a period.

Issue #81 makes several related reports, some of which have their root in the code imported from lambdaworks. If those parts of the issue are not going to be addressed in this repository, then the issue can be labeled as resolvable by this PR.

What is the new behavior?

The fixed method now uses the expected message structure.

Does this introduce a breaking change?

No