starknet-io / types-rs

🐺 Starknet Rust types 🦀
MIT License
65 stars 41 forks source link

Bugfix: binary deserialization `Felt` #89

Closed xrvdg closed 1 month ago

xrvdg commented 2 months ago

Felt supports both human readable and binary serialization, but the binary deserializer was missing.

Does this introduce a breaking change?

Yes, but likely no-one is affected by it as deserialization was not working. The (de)serialization is done with bytes rather than sequences.

Other information

The serialization and deserialization test have been combined. Serialization and deserialization should not be tested separately as that makes it too easy to miss a case.