Closed Yoni-Starkware closed 3 months ago
Attention: Patch coverage is 90.90909%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 78.02%. Comparing base (
faa3e44
) to head (35665c7
).
Files | Patch % | Lines |
---|---|---|
crates/native_blockifier/src/py_validator.rs | 0.00% | 2 Missing :warning: |
crates/blockifier/src/context.rs | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
crates/blockifier/src/blockifier/transaction_executor.rs
line 58 at r2 (raw file):
We don't move it that much, there are two clones for each block. I don't like the implicit copy (a struct might get big in the future).
Note that BouncerWeights
does implement Copy
. It is derived, but we can implement it explicitly to control what gets copied in case the struct gets big. If we use clone()
, everything gets duplicated in an uncontrolled manner.
This change is![Reviewable](https://reviewable.io/review_button.svg)