Closed Yoni-Starkware closed 3 months ago
Attention: Patch coverage is 77.77778%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 78.20%. Comparing base (
c35c254
) to head (917944a
).
Files | Patch % | Lines |
---|---|---|
...lockifier/src/transaction/transaction_execution.rs | 75.00% | 0 Missing and 4 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
crates/blockifier/src/bouncer_test.rs
line 187 at r1 (raw file):
No worries, tx-too-large is covered in this test: https://github.com/starkware-libs/blockifier/blob/7d9ebe996796cc6c4f38a104599630da0177b13c/crates/blockifier/src/blockifier/transaction_executor_test.rs#L240
The test only checks the first case you removed here. Don't we want the case "too_large_with_keccak" and the case "too_larg_with_keccak_ecdsa"?
crates/blockifier/src/concurrency/worker_logic.rs
line 223 at r3 (raw file):
panic!("Bouncer update failed. {error:?}: {error}"); } }
Nonblocking
Suggestion:
if error == TransactionExecutorError::BlockFull {
return false
} else {
// TODO(Avi, 01/07/2024): Consider propagating the error.
panic!("Bouncer update failed. {error:?}: {error}");
}
This change is![Reviewable](https://reviewable.io/review_button.svg)