search

starkware-libs / blockifier

Blockifier is a Rust implementation for the transaction-executing component in the StarkNet sequencer, in charge of creating state diffs and blocks.
Apache License 2.0
170 stars 107 forks source link

refactor(execution): clean TransactionExecutor - move validate to Sta… #1961

Closed Yoni-Starkware closed 3 months ago

Yoni-Starkware commented 3 months ago

…tefulValidator

This change is Reviewable

ArniStarkware commented 3 months ago

crates/blockifier/src/blockifier/stateful_validator.rs line 147 at r2 (raw file):

        &mut self,
        tx: &AccountTransaction,
        mut remaining_gas: u64,

Does this work as intended for sure? What is the expected behavior here? Is the original value supposed to change?

Code quote:

mut remaining_gas: u64,
ArniStarkware commented 3 months ago

crates/blockifier/src/blockifier/stateful_validator.rs line 147 at r2 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…
Does this work as intended for sure? What is the expected behavior here? Is the original value supposed to change?

Well - it does not matter - in any case, this value will not change in the calling function. So we are good.