Closed meship-starkware closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.68%. Comparing base (
6e06e79
) to head (8995b60
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
crates/blockifier/src/transaction/account_transactions_test.rs
line 1269 at r1 (raw file):
block_context.block_info = block_info; // Create the account transaction accurding to the fee type.
Suggestion:
// Create the account transaction according to the fee type.
crates/blockifier/src/transaction/account_transactions_test.rs
line 1302 at r1 (raw file):
I think the first assertion is enough because it indicates that we run the sequential fee transfer, and a test already checks it. WDYT?
You want to remove the second assertion?
Code snippet:
assert_eq!(
*storage.get(&(fee_token_address, seq_key)).unwrap(),
stark_felt!(seq_value)
);
crates/blockifier/src/transaction/account_transactions_test.rs
line 1302 at r1 (raw file):
Yes.
Actually, I think we should remove the first assertion. If we are able to compare the value at the key, then that key obviously exists.
crates/blockifier/src/transaction/account_transactions_test.rs
line 1247 at r7 (raw file):
assert!(!result.is_reverted()); // Check that the sequencer balance was updared (in this case, was not changed).
Suggestion:
// Check that the sequencer balance was updated (in this case, was not changed).
… the sender
This change is![Reviewable](https://reviewable.io/review_button.svg)