starkware-libs / blockifier

Blockifier is a Rust implementation for the transaction-executing component in the StarkNet sequencer, in charge of creating state diffs and blocks.
Apache License 2.0
171 stars 99 forks source link

fix(transaction): set default transaction version to three in invoke … #1967

Closed meship-starkware closed 4 weeks ago

meship-starkware commented 1 month ago

…function macro


This change is Reviewable

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.42%. Comparing base (48942ed) to head (5706f77). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1967 +/- ## ========================================== - Coverage 78.45% 78.42% -0.03% ========================================== Files 62 63 +1 Lines 8970 9031 +61 Branches 8970 9031 +61 ========================================== + Hits 7037 7083 +46 - Misses 1486 1501 +15 Partials 447 447 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

barak-b-starkware commented 1 month ago

crates/blockifier/src/concurrency/worker_logic_test.rs line 214 at r9 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…
It is used here: https://github.com/starkware-libs/blockifier/blob/966013b72c394c0208de400bc5f8f7271f05caa8/crates/blockifier/src/transaction/transactions.rs#L237 for non-test purpose

What is the meaning of "then what might come an heavy struct"? I'm trying to say that it can't be heavy, not soon, and not in the long run.

barak-b-starkware commented 1 month ago

crates/blockifier/src/concurrency/worker_logic_test.rs line 214 at r9 (raw file):

Previously, noaov1 (Noa Oved) wrote…
Some external user of the blockifier can choose to have a heavy struct (as you mentioned, it can grow uncontrollably).

Understood (:

barak-b-starkware commented 1 month ago

crates/blockifier/src/transaction/transactions_test.rs line 1686 at r17 (raw file):


    let expected_resource_bounds = vec![
        StarkFelt::from(2u32),          // Length of ResourceBounds array.

Suggestion:

StarkFelt::TWO