Closed meship-starkware closed 4 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.42%. Comparing base (
48942ed
) to head (5706f77
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
crates/blockifier/src/concurrency/worker_logic_test.rs
line 214 at r9 (raw file):
It is used here: https://github.com/starkware-libs/blockifier/blob/966013b72c394c0208de400bc5f8f7271f05caa8/crates/blockifier/src/transaction/transactions.rs#L237 for non-test purpose
What is the meaning of "then what might come an heavy struct"? I'm trying to say that it can't be heavy, not soon, and not in the long run.
crates/blockifier/src/concurrency/worker_logic_test.rs
line 214 at r9 (raw file):
Some external user of the blockifier can choose to have a heavy struct (as you mentioned, it can grow uncontrollably).
Understood (:
crates/blockifier/src/transaction/transactions_test.rs
line 1686 at r17 (raw file):
let expected_resource_bounds = vec![ StarkFelt::from(2u32), // Length of ResourceBounds array.
Suggestion:
StarkFelt::TWO
…function macro
This change is