search

starkware-libs / blockifier

Blockifier is a Rust implementation for the transaction-executing component in the StarkNet sequencer, in charge of creating state diffs and blocks.
Apache License 2.0
171 stars 99 forks source link

chore(concurrency): add log messages to the concurrency module #1990

Open avi-starkware opened 1 month ago

avi-starkware commented 1 month ago

This change is Reviewable

avi-starkware commented 1 month ago

Example log messages:

[ThreadId(10684)] Finished executing transaction index 1.
[ThreadId(10684)] Validating transaction index 1.
[ThreadId(10684)] Finished validating transaction index 1 with no abort.
[ThreadId(10684)] Executing transaction index 11.
[ThreadId(10684)] Finished executing transaction index 11.
[ThreadId(10684)] Executing transaction index 12.
[ThreadId(10684)] Finished executing transaction index 12.
[ThreadId(10684)] Validating transaction index 4.
[ThreadId(10684)] Aborted transaction index 4.
[ThreadId(10684)] Executing transaction index 4.
codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.61%. Comparing base (d924c79) to head (03bc0b9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1990 +/- ## ======================================= Coverage 78.61% 78.61% ======================================= Files 62 62 Lines 8895 8895 Branches 8895 8895 ======================================= Hits 6993 6993 Misses 1455 1455 Partials 447 447 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

avi-starkware commented 1 month ago

It might make better sense to add metrics for the batcher operations and individual threads. This way we will be able to monitor and debug performance without cluttering the logs.