search

starkware-libs / blockifier

Blockifier is a Rust implementation for the transaction-executing component in the StarkNet sequencer, in charge of creating state diffs and blocks.
Apache License 2.0
170 stars 107 forks source link

refactor: move skip validation check to py_validator #2013

Closed Yael-Starkware closed 3 months ago

Yael-Starkware commented 3 months ago

This change is Reviewable

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 7.50000% with 37 lines in your changes missing coverage. Please review.

Project coverage is 79.89%. Comparing base (73c3821) to head (295492c). Report is 39 commits behind head on main.

Files Patch % Lines
crates/native_blockifier/src/py_validator.rs 0.00% 26 Missing :warning:
...es/blockifier/src/blockifier/stateful_validator.rs 21.42% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2013 +/- ## ========================================== - Coverage 80.17% 79.89% -0.28% ========================================== Files 69 69 Lines 9739 9739 Branches 9739 9739 ========================================== - Hits 7808 7781 -27 - Misses 1471 1501 +30 + Partials 460 457 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ArniStarkware commented 3 months ago

-- commits line 2 at r1:

Previously, Yael-Starkware (YaelD) wrote…
blocking until python tests run and pass

link?