search

starkware-libs / cairo-lang

Apache License 2.0
1.35k stars 262 forks source link

request: support eth-hash >= 0.3.2 #30

Closed antazoey closed 2 years ago

antazoey commented 2 years ago

Feature Request

Issue

Right now, eth-hash is pinned to 0.2.0. Other dependencies in my project require eth-hash >= 0.3.2. I am wondering if there is anything we can do?

Possible Solution

Either upgrading eth-hash to >= 0.3.2 or relaxing the pin constraints

trevis-dev commented 2 years ago

This also comes up in a fresh install of cairo-lang for another of its dependencies. Was it eth-utils ?

antazoey commented 2 years ago

Yes, eth-utils also has a version that outside the range I am able to support in my environment as well. I think it is 1 minor version too small (1.9 where I need at least 1.10). I don't remember but can double check. I don't know what is driving what either; I see the eth-hash pin here though: https://github.com/starkware-libs/cairo-lang/blob/master/scripts/requirements-gen.txt#L4

antazoey commented 2 years ago

It seems like this issue has been resolved! I think we can close :) Thank you