Call detect_crate_for whenever project manifest file is saved

starkware-libs / cairo

Cairo is the first Turing-complete language for creating provable programs for general computation.

Apache License 2.0

1.53k stars 474 forks source link

Call detect_crate_for whenever project manifest file is saved #6236

Closed mkaput closed 1 week ago

mkaput commented 3 weeks ago

Refreshes when Scarb.toml/Scarb.lock is saved. Mind that it is better to make an unnecessary refresh than not to do it and work on a stale workspace state!

piotmag769 commented 3 weeks ago

It seems that it already works for Scarb.toml 🤔 At least for me

mkaput commented 3 weeks ago

but it doesn't listen for Scarb.lock nor cairo_project.toml: https://github.com/starkware-libs/cairo/blob/85275d9efa2d36dc60798f0a849477f9afc55217/crates/cairo-lang-language-server/src/lib.rs#L736

I know you have to apply this change at least: https://github.com/starkware-libs/cairo/compare/main...mkaput/new-project-model-v2#diff-ab83b8926900a6d4779007745456106fcd20f62e7b951a303b1b233967074705R668-R678

piotmag769 commented 2 weeks ago

Partially solved by #6316, Scarb.lock is todo

piotmag769 commented 1 week ago

Created new issue for Scarb.lock #6347