search

starkware-libs / starknet-specs

94 stars 76 forks source link

Mismatched versions in specification files #181

Closed FabijanC closed 11 months ago

FabijanC commented 11 months ago

As of spec version v0.6.0-rc5, while api/starknet_api_openrpc.json has version: 0.6.0, the write and trace files have 0.5.0.

Is this on purpose? Should the versioning of every file really be independent? I feel like something is wrong because in v0.5.1, the version in all three files was indeed 0.5.1.

If this really is a mistake, a good idea would be to improve the validation workflow this repository uses (namely validate.js). Perhaps it could use the version property in package.json as the source of truth, and check all the spec files against that. I'd be willing to make a contribution.

Mirko-von-Leipzig commented 11 months ago

Fairly sure it's not on purpose. I think go ahead with adding the CI check; always nice to not worry about it.