search

starkware-libs / starknet-specs

94 stars 76 forks source link

txHash field missing in the BLOCK_BODY_WITH_RECEIPTS spec #209

Closed thiagodeev closed 1 month ago

thiagodeev commented 4 months ago

The BLOCK_BODY_WITH_TXS returns the TXN + TxHash as the TXN doesn't have the txHash on it, but that doesn't happen with the BLOCK_BODY_WITH_RECEIPTS that returns the transactions + the receipts. It should also specify that a transaction hash should be returned as happens with the BLOCK_BODY_WITH_TXS because the description says that it is a list of full transactions.

BLOCK_BODY_WITH_TXS: https://github.com/starkware-libs/starknet-specs/blob/304b952121dafe47c013ed2c4c39bef4cf4c2823/api/starknet_api_openrpc.json#L1376-L1397

BLOCK_BODY_WITH_RECEIPTS: https://github.com/starkware-libs/starknet-specs/blob/304b952121dafe47c013ed2c4c39bef4cf4c2823/api/starknet_api_openrpc.json#L1412-L1429

ArielElp commented 1 month ago

The reason that it was not included was that the transaction receipt already includes the hash, hence it would be duplicated information in this request.