starkware-libs / starknet-specs

94 stars 76 forks source link

Starknet WebSocket specification proposal #211

Closed amanusk closed 1 month ago

amanusk commented 4 months ago

How to read this spec


This change is Reviewable

ittaysw commented 4 months ago

What is the behavior of these subscriptions when a node is syncing? E.g. I subscribed to events, will i get all events as it is going through blocks? A node may be syncing back as well, what is the meaning of 'latest' then? And if two nodes are syncing on the same range, one forward, one backward, will they send different events on the stream?

Seems to me like we should just not allow subscribing when a node is syncing, only when it is fully synced. Then we can also remove the syncing status call.

amanusk commented 3 months ago

Latest changes based on discussions above

Open question:

These are also questions for Full nodes and how much does this complicate implementation

amanusk commented 2 months ago

Update: Added the option to subscribe to up to 1024 blocks back, and the accompanying error