starkware-libs / stwo

Apache License 2.0
213 stars 64 forks source link

Derive Serde for StarkProof Struct #731

Closed AbdelStark closed 1 month ago

AbdelStark commented 1 month ago

Title

Derive Serde for StarkProof Struct

Description

Currently, the StarkProof struct does not implement serialization and deserialization via serde, which is necessary for our application to easily convert proofs to and from JSON format. Implementing serde will also allow for better interoperability with other services that consume or produce JSON data.

Expected Behavior

After implementing serde:

Possible Solution

Additional Context

manoahLinks commented 1 month ago

can i hop on this ?

MayowaObisesan commented 1 month ago

Hi @AbdelStark Can I take up this issue?

MSghais commented 1 month ago

Can I jump on this, please? I go through the repo a bit and check what needs to be changed also on the attributes for Deserialization/Serialization. I think I can give an ETA in few hours

AbdelStark commented 1 month ago

Can I jump on this, please? I go through the repo a bit and check what needs to be changed also on the attributes for Deserialization/Serialization. I think I can give an ETA in few hours

Ok please give it a try.

AbdelStark commented 1 month ago

can i hop on this ?

Assigned to @MSghais for now. Please contribute to another Starknet related repo meanwhile.

AbdelStark commented 1 month ago

Hi @AbdelStark Can I take up this issue?

Assigned to @MSghais for now. Please contribute to another Starknet related repo meanwhile.

MayowaObisesan commented 1 month ago

Alright @AbdelStark . Thanks