search

starkware-libs / stwo

Apache License 2.0
224 stars 68 forks source link

Create MLE eval prover component #804

Open andrewmilson opened 2 weeks ago

andrewmilson commented 2 weeks ago

This change is Reviewable

andrewmilson commented 2 weeks ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andrewmilson and the rest of your teammates on Graphite Graphite

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.95%. Comparing base (1f9187e) to head (f0d2917).

Files with missing lines Patch % Lines
crates/prover/src/core/air/accumulation.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #804 +/- ## ========================================== + Coverage 92.76% 92.95% +0.18% ========================================== Files 89 89 Lines 12032 12037 +5 Branches 12032 12037 +5 ========================================== + Hits 11162 11189 +27 + Misses 763 741 -22 Partials 107 107 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andrewmilson commented 2 weeks ago

crates/prover/src/examples/xor/gkr_lookups/mle_eval.rs line 211 at r2 (raw file):

Previously, andrewmilson (Andrew Milson) wrote…
Updated to use the offset but honestly might be slower due to the bad access patterns.

Actually I'm wrong never mind