search

starlake-ai / jsqltranspiler

Rewrite BigQuery, Redshift, Snowflake and Databricks queries into DuckDB compatible SQL (with deep transformation of functions, data types and format characters) using Java.
https://starlake.ai/starlake/
Other
28 stars 1 forks source link

failing snapshot action #28

Closed stbischof closed 1 week ago

stbischof commented 4 weeks ago

the snapshot build action is broken because of some test.

could you please fix the test/impl

manticore-projects commented 4 weeks ago

Yes, we are aware of this and we are working on getting Snapshot deployment of JSQLParser working again. Give me a few days on this, we are depending on @Wumpz here.

manticore-projects commented 3 weeks ago

This is becoming a showstopper and unfortunately only @Wumpz can fix the JSQLParser snapshot publishing. So we have two options: a) chose our own Maven coordinates for JSQLParser or b) include a precompiled JSQLParser (again, at least until this is fixed)

manticore-projects commented 3 weeks ago

There are still 2 tests failing on GitHub only -- and I don't have any idea why exactly.

hayssams commented 3 weeks ago

It has probably something to do with the precision, scale of the tests. Most of them fail one my Mac for this simple reason.

manticore-projects commented 3 weeks ago

I have reworked the Tests and the use of CSV to ensure similar precision on different platforms. However, there are still 4 tests failing on GitHub and a few more on @hayssams Apple system. I will need to setup a clean virtual machine to understand what's going on.

manticore-projects commented 1 week ago

I have finally found and understood the 4 failing test cases. It was about "NULLS FIRST DEFAULT" order and I set this as a configuration for the test case now -- and the tests succeeded on GitHub. Also I have removed the dependency to Linux SED, so everything should work now.