starlightknown / Cyberon

Cyberon- a discord bot for hackathon servers made by using discord.py
https://starlightknown.github.io/Cyberon/#/
MIT License
19 stars 12 forks source link

feat: add mlh command (Sourcery refactored) #103

Closed sourcery-ai[bot] closed 3 years ago

sourcery-ai[bot] commented 3 years ago

Pull Request #102 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to the original Pull Request

    Incorporate changes via command line
    git fetch https://github.com/starlightknown/Cyberon pull/102/head
    git merge --ff-only FETCH_HEAD
    git push

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.37%.

Quality metrics Before After Change
Complexity 10.15 🙂 9.31 🙂 -0.84 👍
Method Length 73.22 🙂 73.09 🙂 -0.13 👍
Working memory 9.59 🙂 9.43 🙂 -0.16 👍
Quality 61.46% 🙂 62.83% 🙂 1.37% 👍
Other metrics Before After Change
Lines 733 759 26
Changed files Quality Before Quality After Quality Change
bot.py 67.13% 🙂 69.88% 🙂 2.75% 👍
scrapper.py 90.20% ⭐ 90.20% ⭐ 0.00%
cogs/Utils.py 56.41% 🙂 57.51% 🙂 1.10% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
cogs/Utils.py GeneralCog.avatar 37 ⛔ 304 ⛔ 15 😞 18.40% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
cogs/Utils.py GeneralCog.userinfo 33 ⛔ 373 ⛔ 14 😞 19.60% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
bot.py on_message_edit 7 ⭐ 108 🙂 24 ⛔ 46.87% 😞 Extract out complex expressions
cogs/Utils.py GeneralCog.wiki 8 ⭐ 121 😞 12 😞 54.78% 🙂 Try splitting into smaller methods. Extract out complex expressions
bot.py on_member_remove 5 ⭐ 147 😞 11 😞 56.38% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!