Closed divyanshu887 closed 3 years ago
Could you add gifs from giphy online? The gifs from other site are not visible
❌ Merging this PR will decrease code quality in the affected files by 0.92%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 0.33 ⭐ | 0.33 ⭐ | 0.00 |
Method Length | 50.21 ⭐ | 50.79 ⭐ | 0.58 👎 |
Working memory | 9.65 🙂 | 10.05 😞 | 0.40 👎 |
Quality | 73.26% 🙂 | 72.34% 🙂 | -0.92% 👎 |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 195 | 204 | 9 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
cogs/general.py | 73.26% 🙂 | 72.34% 🙂 | -0.92% 👎 |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
cogs/general.py | general.serverinfo | 1 ⭐ | 175 😞 | 12 😞 | 55.84% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
cogs/general.py | general.eight_ball | 0 ⭐ | 77 🙂 | 22 ⛔ | 58.94% 🙂 | Extract out complex expressions |
cogs/general.py | general.bitcoin | 0 ⭐ | 71 🙂 | 12 😞 | 69.57% 🙂 | Extract out complex expressions |
cogs/general.py | general.ping | 0 ⭐ | 61 ⭐ | 12 😞 | 71.12% 🙂 | Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Let us know what you think of it by mentioning @sourcery-ai in a comment.
Could you add gifs from giphy online? The gifs from other site are not visible
i have added this time only from giphy
Thank you so much for contributing!
@all-contributors please add @divyanshu887 for videos
@starlightknown
I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.
@all-contributors please add @divyanshu887 for video
@starlightknown
I've put up a pull request to add @divyanshu887! :tada:
solved issue(#25 )