search

starlightprivate / flash2

nodejs app
0 stars 0 forks source link

Fix/email validation #245

Closed asharma-ror closed 7 years ago

asharma-ror commented 7 years ago

now abc@xyz will be invalid on FE

This change is Reviewable

vodolaz095 commented 7 years ago

i generally approve this PR. @asharma-ror - please, review what regexes they use for email validation https://github.com/chriso/validator.js/blob/master/lib/isEmail.js

They can be not regex save. But anyway, i approve your commit and it is your opinion to merge or continue work

asharma-ror commented 7 years ago

I've removed the minimum length validation from email because 6 characters are already covered by email validation & domain name validation togetherly. Also only one error message is shown as a validation criteria fails