starlingcode / Via-for-Rack

MIT License
24 stars 8 forks source link

Will not compile on Windows 10 #12

Closed caecos closed 5 years ago

caecos commented 5 years ago

$ make g++ -Wsuggest-override -std=c++11 -DBUILD_VIRTUAL -I./Via/modules/inc -I./Via/synthesis/inc -I./Via/io/inc -I./Via/ui/inc -DSLUG=Starling_Via_Meta -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_WIN -D_USE_MATH_DEFINES -c -o build/src/Via_Meta.cpp.o src/Via_Meta.cpp src/Via_Meta.cpp:1:10: fatal error: meta.hpp: No such file or directory

include "meta.hpp"

      ^~~~~~~~~~

compilation terminated.

caecos commented 5 years ago

$ make g++ -Wsuggest-override -std=c++11 -DBUILD_VIRTUAL -I./Via/modules/inc -I./Via/synthesis/inc -I./Via/io/inc -I./Via/ui/inc -DSLUG=Starling_Via_Meta -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_WIN -D_USE_MATH_DEFINES -c -o build/src/Via_Meta.cpp.o src/Via_Meta.cpp src/Via_Meta.cpp:1:10: fatal error: meta.hpp: No such file or directory

include "meta.hpp"

      ^~~~~~~~~~

compilation terminated.

liquidcitymotors commented 5 years ago

Hi @caecos! Did you clone the submodules? This is a pre-release version so the readme doesn't mention the need to do that, my apologies. In a similar fashion to the Fundamental plugins, you need to run

git submodule update --init --recursive

caecos commented 5 years ago

Yes...and still this error: make: *** [../../compile.mk:65: build/src/Via_Scanner.cpp.o] Error 1

SteveRussell33 commented 5 years ago

This is what I get:

g++ -Wsuggest-override -std=c++11 -DBUILD_VIRTUAL -I./Via/modules/inc -I./Via/synthesis/inc -I./Via/io/inc -I./Via/ui/inc -DSLUG=Starling_Via -fPIC -I../../include -I../../dep/include -DVERSION=0.9.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_WIN -D_USE_MATH_DEFINES -c -o build/src/Via_Meta.cpp.o src/Via_Meta.cpp In file included from ./Via/io/inc/via_virtual_module.hpp:14, from ./Via/io/inc/via_platform_binding.hpp:18, from ./Via/ui/inc/user_interface.hpp:13, from ./Via/modules/inc/meta.hpp:11, from src/Via_Meta.cpp:1: ./Via/synthesis/inc/dsp.hpp: In function 'int32_t __SSAT(int32_t, int32_t)': ./Via/synthesis/inc/dsp.hpp:573:25: warning: left shift of negative value [-Wshift-negative-value] } else if (X < ((-1 << Y) + 1)) { ^ ./Via/synthesis/inc/dsp.hpp:574:18: warning: left shift of negative value [-Wshift-negative-value] return ((-1 << Y) + 1); ^ g++ -Wsuggest-override -std=c++11 -DBUILD_VIRTUAL -I./Via/modules/inc -I./Via/synthesis/inc -I./Via/io/inc -I./Via/ui/inc -DSLUG=Starling_Via -fPIC -I../../include -I../../dep/include -DVERSION=0.9.0 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_WIN -D_USE_MATH_DEFINES -c -o build/src/Via_Scanner.cpp.o src/Via_Scanner.cpp In file included from ./Via/io/inc/via_virtual_module.hpp:14, from ./Via/io/inc/via_platform_binding.hpp:18, from ./Via/ui/inc/user_interface.hpp:13, from ./Via/modules/inc/scanner.hpp:17, from src/Via_Scanner.cpp:1: ./Via/synthesis/inc/dsp.hpp: In function 'int32_t __SSAT(int32_t, int32_t)': ./Via/synthesis/inc/dsp.hpp:573:25: warning: left shift of negative value [-Wshift-negative-value] } else if (X < ((-1 << Y) + 1)) { ^ ./Via/synthesis/inc/dsp.hpp:574:18: warning: left shift of negative value [-Wshift-negative-value] return ((-1 << Y) + 1); ^ In file included from ./Via/io/inc/via_virtual_module.hpp:14, from ./Via/io/inc/via_platform_binding.hpp:18, from ./Via/ui/inc/user_interface.hpp:13, from ./Via/modules/inc/scanner.hpp:17, from src/Via_Scanner.cpp:1: ./Via/synthesis/inc/dsp.hpp: At global scope: ./Via/synthesis/inc/dsp.hpp:807:23: error: conflicting declaration of C function 'int32_t getSampleQuinticSplineDeltaValue(uint32_t, uint32_t, uint32_t, int32_t, uint32_t)' static inline int32_t getSampleQuinticSplineDeltaValue(uint32_t phase, uint32_t morph, ^~~~~~~~ ./Via/synthesis/inc/dsp.hpp:743:23: note: previous declaration 'int32_t getSampleQuinticSplineDeltaValue(uint32_t, uint32_t, uint32_t, int32_t)' static inline int32_t getSampleQuinticSplineDeltaValue(uint32_t phase, uint32_t morph, ^~~~~~~~ make: *** [../../compile.mk:65: build/src/Via_Scanner.cpp.o] Error 1

SteveRussell33 commented 5 years ago

I got it to compile by commenting out lines 743-805 of Via-for-VCVRack\Via\synthesis\inc\dsp.hpp

caecos commented 5 years ago

Can you post a Windows plugin?

Obtenez Outlook pour iOShttps://aka.ms/o0ukef


De : SteveRussell33 notifications@github.com Envoyé : lundi, janvier 14, 2019 12:26 À : liquidcitymotors/Via-for-VCVRack Cc : caecos; Mention Objet : Re: [liquidcitymotors/Via-for-VCVRack] Will not compile on Windows 10 (#12)

I got it to compile by commenting out lines 743-805 of Via-for-VCVRack\Via\synthesis\inc\dsp.hpp

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/liquidcitymotors/Via-for-VCVRack/issues/12#issuecomment-454088994, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AeRig0ZilLL4tiKKCpY6cl8WGlNIdQwTks5vDL2tgaJpZM4ZKNOj.

caecos commented 5 years ago

Thx, I will try it tonight after works... regards...

Obtenez Outlook pour iOShttps://aka.ms/o0ukef


De : SteveRussell33 notifications@github.com Envoyé : lundi, janvier 14, 2019 12:42 À : liquidcitymotors/Via-for-VCVRack Cc : caecos; Mention Objet : Re: [liquidcitymotors/Via-for-VCVRack] Will not compile on Windows 10 (#12)

Starling_Via-0.9.0-win.zip

https://drive.google.com/open?id=1jlYA1BqRk4lWZJi1vTA0CXyZU3r_Ubo3

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/liquidcitymotors/Via-for-VCVRack/issues/12#issuecomment-454094633, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AeRig7O6s73PggDbhGuHPcqmm5XDNaN6ks5vDMFtgaJpZM4ZKNOj.

liquidcitymotors commented 5 years ago

@SteveRussell33 Thanks for tracking that down. I will fix on the next commit. @caecos I am sorry that I have not been able to properly test a windows build; I have been very busy with other aspects of this project. I will find a windows machine and try to build after work tonight.

caecos commented 5 years ago

Many thanks and do not apologized... you offers your works free and that all we can wait for...regards...

Obtenez Outlook pour iOShttps://aka.ms/o0ukef


De : Will Mitchell notifications@github.com Envoyé : lundi, janvier 14, 2019 14:51 À : liquidcitymotors/Via-for-VCVRack Cc : caecos; Mention Objet : Re: [liquidcitymotors/Via-for-VCVRack] Will not compile on Windows 10 (#12)

@SteveRussell33https://github.com/SteveRussell33 Thanks for tracking that down. I will fix on the next commit. @caecoshttps://github.com/caecos I am sorry that I have not been able to properly test a windows build; I have been very busy with other aspects of this project. I will find a windows machine and try to build after work tonight.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/liquidcitymotors/Via-for-VCVRack/issues/12#issuecomment-454138392, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AeRig4mh8nkpidybMhDvcN5L55Q-tEdWks5vDN-3gaJpZM4ZKNOj.

caecos commented 5 years ago

Unable to download the Dropbox files...

caecos commented 5 years ago

Unable to download the file... error file does not exist...

Obtenez Outlook pour iOShttps://aka.ms/o0ukef


De : SteveRussell33 notifications@github.com Envoyé : lundi, janvier 14, 2019 12:42 À : liquidcitymotors/Via-for-VCVRack Cc : caecos; Mention Objet : Re: [liquidcitymotors/Via-for-VCVRack] Will not compile on Windows 10 (#12)

Starling_Via-0.9.0-win.zip

https://drive.google.com/open?id=1jlYA1BqRk4lWZJi1vTA0CXyZU3r_Ubo3

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/liquidcitymotors/Via-for-VCVRack/issues/12#issuecomment-454094633, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AeRig7O6s73PggDbhGuHPcqmm5XDNaN6ks5vDMFtgaJpZM4ZKNOj.

SteveRussell33 commented 5 years ago

Sorry, thought you grabbed the file after I uploaded it to my GoogleDrive - which I then cleared out of some old files. Reuploaded: https://drive.google.com/open?id=1s-vX2sj-b3jNjj5r5JBHpYMMJiNHxEdn

liquidcitymotors commented 5 years ago

@caecos OK, in the latest commit, I went ahead and fixed the duplicate definition that @SteveRussell33 spotted, thanks again for that! Hopefully it builds for you now. Looking forward to submitting a stable release for the plugin manager in the (hopefully near) future.

caecos commented 5 years ago

Compile like a cool breeze...thanks and bravo for the improvements...regards

SteveRussell33 commented 5 years ago

@liquidcitymotors No problem my friend, happy to help! Love the panel artwork btw! Very nice.

caecos commented 5 years ago

I have downloaded the and it works well... quite similar to my compilation now... with your help... indeed...

Obtenez Outlook pour iOShttps://aka.ms/o0ukef


De : SteveRussell33 notifications@github.com Envoyé : mardi, janvier 15, 2019 13:20 À : liquidcitymotors/Via-for-VCVRack Cc : caecos; Comment Objet : Re: [liquidcitymotors/Via-for-VCVRack] Will not compile on Windows 10 (#12)

Sorry, thought you grabbed the file after I uploaded it to my GoogleDrive - which I then cleared out of some old files. Reuploaded: https://drive.google.com/open?id=1s-vX2sj-b3jNjj5r5JBHpYMMJiNHxEdn

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/liquidcitymotors/Via-for-VCVRack/issues/12#issuecomment-454496431, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AeRigzK86xtbbVoJAUnr3Mi93KU-20DAks5vDhvhgaJpZM4ZKNOj.