search

starlinglab / integrity-v2

Monorepo for the next iteration of Starling Lab's integrity pipeline.
MIT License
1 stars 3 forks source link

[webhook] index a list of predefined attributes #35

Closed williamchong closed 5 months ago

williamchong commented 5 months ago

It seems unnecessary to have separate slices and separate calls to AA just for the indexed attributes. It would be simpler to combine them into just one slice, after all the aa.PostKV type is designed to support this.

I though indexing is controlled by the query string index=1, is that not the case and i just need to set the type?

makew0rld commented 5 months ago

Sorry, the API is confusing. Even when index=1 is set, the key is only indexed if it has a type set. So you can avoid indexing keys even with index=1 by just not setting the type field. That is what I would recommend doing here.

williamchong commented 5 months ago

Rewrote the PR to always use index=1 @makew0rld