Exif Viewer broke somewhere around 1.7.9

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Install >=1.7.9 == 2.0.0, 2.0.1, etc
2. Open any flickr photo
3. try viewing exif

Please provide any additional information below.
---------------------

Problem:
Method: gpsFrame(gps) 
File: exif_inject.js / exif.content.js

I ran the inspector and noticed that the function gpsFrame(gps) was receiving a 
null for gps
This was throwing out an exception. this was causing the popup to not be shown.
I fixed it in my copy and it works

You might want to take a look at it
Cheers
Kalyan

Original issue reported on code.google.com by nvsnkalyan on 27 Mar 2012 at 11:19

[GoogleCodeExporter]

it's quite odd cuz there is no gpsFrame method in obfuscated code which I've 
released:

a("<div />").attr("id", "exifGpsTab").append(a("<iframe />").css("width", 
"100%").css("min-height", "350px").css("border", "1px solid 
#cccccc").attr("src", "http://maps.google.com/maps?q=" + j.lat + "," + j.lng + 
"&ll=" + j.lat + "," + j.lng + "&output=embed&z=8&t=h"))

Original comment by andry.virvich on 28 Mar 2012 at 2:47

[GoogleCodeExporter]

The variable j in this case was is going null. So j.lat was throwing exception.
And this fragment is exactly same as that of gpsFrame (in the older version)

I have had obfuscation ruin my JS before. So i am going to suspect it.

But in any case, you should definitely add a null check for that variable.

Original comment by nvsnkalyan on 28 Mar 2012 at 7:26

[GoogleCodeExporter]

oh, gotcha, thx! fixed in 2.0.4

Original comment by andry.virvich on 28 Mar 2012 at 9:08

• Changed state: Fixed