starnutoditopo / react-typescript-flight-indicators

A React + Typescript porting of react-flight-indicators (https://github.com/skyhop/react-flight-indicators)
GNU General Public License v3.0
6 stars 7 forks source link

Question about changing the size #1

Open kyungbaa opened 1 year ago

kyungbaa commented 1 year ago

I have a question about changing the size of the react-typescript-flight-indicators library. I tried to change the width and height using the following code, but it didn't work:

<HeadingIndicator
heading={Math.random() * 360}
showBox={false}
width={20}
height={20}
/>

Is there any other way to change the size of the indicators?

starnutoditopo commented 1 year ago

Hi!

Sorry, but at the moment I cannot give you support. I may come back to this question some time later.

Cheers, Xc

On Fri, Apr 21, 2023 at 4:44 AM Lee Hoo Kyung @.***> wrote:

I have a question about changing the size of the react-typescript-flight-indicators library. I tried to change the width and height using the following code, but it didn't work:

<HeadingIndicator heading={Math.random() * 360} showBox={false} width={20} height={20} />

Is there any other way to change the size of the indicators?

— Reply to this email directly, view it on GitHub https://github.com/starnutoditopo/react-typescript-flight-indicators/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK3JPKBNTZ7MCEK3DBFSD3XCHX7RANCNFSM6AAAAAAXGJBDKE . You are receiving this because you are subscribed to this thread.Message ID: @.*** com>

bpmooch commented 1 year ago

@kyungbaa this should be fixed. To maintain the "squareness" of the gauges such as the heading indicator, a single size prop is accepted that takes a css string such as "250px" and is applied to the height and width property of the gauges. To fix your example:

<HeadingIndicator
  heading={Math.random() * 360}
  showBox={false}
  size={"200px"}
/>

jk I need to push a publish a new version, stand by

bpmooch commented 1 year ago

@starnutoditopo how to publish to npm? Are you using an account you own? Can you push latest to npm? version needs to be bumped

starnutoditopo commented 1 year ago

I never pushed to npm. I think I neither have an account. Feel free to create one, if you want.

On Sat, Jul 1, 2023 at 2:08 AM Chris Mucciolo @.***> wrote:

@starnutoditopo https://github.com/starnutoditopo how to publish to npm? Are you using an account you own? Can you push latest to npm? version needs to be bumped

— Reply to this email directly, view it on GitHub https://github.com/starnutoditopo/react-typescript-flight-indicators/issues/1#issuecomment-1615290086, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK3JPIYINTHUWN4RICH2V3XN5S7VANCNFSM6AAAAAAXGJBDKE . You are receiving this because you were mentioned.Message ID: <starnutoditopo/react-typescript-flight-indicators/issues/1/1615290086@ github.com>

bpmooch commented 1 year ago

@starnutoditopo I am unable to publish a version to npm. https://www.npmjs.com/package/react-typescript-flight-indicators if you look here, you can see that you are the only collaborator? Perhaps you can add me as a collaborator in npm?

starnutoditopo commented 1 year ago

Ok, I'll check it out.

On Tue, Jul 4, 2023 at 4:37 AM Chris Mucciolo @.***> wrote:

@starnutoditopo https://github.com/starnutoditopo I am unable to publish a version to npm. https://www.npmjs.com/package/react-typescript-flight-indicators if you look here, you can see that you are the only collaborator? Perhaps you can add me as a collaborator in npm?

— Reply to this email directly, view it on GitHub https://github.com/starnutoditopo/react-typescript-flight-indicators/issues/1#issuecomment-1619378573, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK3JPI6NBR6CYR6FLJW7PLXON6WJANCNFSM6AAAAAAXGJBDKE . You are receiving this because you were mentioned.Message ID: <starnutoditopo/react-typescript-flight-indicators/issues/1/1619378573@ github.com>

starnutoditopo commented 1 year ago

Hi!

I needed some time to restore my access to NPM, sorry. I can now add you as a maintainer, but I need your NPM ( https://www.npmjs.com/ ) username. Can you provide it to me?

Thanks!

On Tue, Jul 4, 2023 at 4:37 AM Chris Mucciolo @.***> wrote:

@starnutoditopo https://github.com/starnutoditopo I am unable to publish a version to npm. https://www.npmjs.com/package/react-typescript-flight-indicators if you look here, you can see that you are the only collaborator? Perhaps you can add me as a collaborator in npm?

— Reply to this email directly, view it on GitHub https://github.com/starnutoditopo/react-typescript-flight-indicators/issues/1#issuecomment-1619378573, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK3JPI6NBR6CYR6FLJW7PLXON6WJANCNFSM6AAAAAAXGJBDKE . You are receiving this because you were mentioned.Message ID: <starnutoditopo/react-typescript-flight-indicators/issues/1/1619378573@ github.com>

bpmooch commented 1 year ago

same as on here, "bpmooch"

bpmooch commented 1 year ago

@starnutoditopo any updates?

starnutoditopo commented 1 year ago

@starnutoditopo any updates?

@bpmooch : you should have received an invitation to join the project as maintainer. I see your invitation pending at https://www.npmjs.com/package/react-typescript-flight-indicators/access Check it out!