hap-nodejs should not be in dependencies

staromeste / homebridge-http-advanced-accessory

Supports all devices on HomeBridge Platform / Bridges devices to http

Apache License 2.0

67 stars 23 forks source link

hap-nodejs should not be in dependencies #27

Open funkyremi opened 4 years ago

funkyremi commented 4 years ago

Hello,

Here's the log I'm getting when running this plugin with homebridge: The plugin "homebridge-http-advanced-accessory" defines 'homebridge' and/or 'hap-nodejs' in their 'dependencies' section, meaning they carry an additional copy of homebridge and hap-nodejs. This not only wastes disk space, but also can cause major incompatibility issues and thus is considered bad practice. Please inform the developer to update their plugin!

shanemcw commented 3 years ago

Fix: remove "hap-nodejs": ">=0.4.25", in "dependencies": in package.json