search

starostka / 02476-mlops

Project work in 02476 Machine Learning Operations at the Technical University of Denmark (DTU)
https://starostka.github.io/02476-mlops/
Other
2 stars 1 forks source link

Fix long workflows #36

Closed philgzl closed 1 year ago

philgzl commented 1 year ago

Trying to fix very long workflows due to the torch-sparse install taking ages. This was partially solved in #31 by specifying the install URL, but it was still broken for the MacOS workflow.

Also removed the torch pre-install workaround as #31 fixed it.

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@f594958). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage        ?   13.11%           
=======================================
  Files           ?        4           
  Lines           ?      122           
  Branches        ?        0           
=======================================
  Hits            ?       16           
  Misses          ?      106           
  Partials        ?        0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

philgzl commented 1 year ago

Okay seems like it's fixed now, I removed the manual torch install from the GitHub workflow and moved it to the Makefile to run it only when it's necessary, i.e. on MacOS. Also forcing CPU PyG installs for MacOS (no CUDA support) and Windows (causes a crash) in the Makefile.