search

starpu-runtime / starpu

This is a mirror of https://gitlab.inria.fr/starpu/starpu where our development happens, but contributions are welcome here too!
https://starpu.gitlabpages.inria.fr/
GNU Lesser General Public License v2.1
58 stars 13 forks source link

Fix missing CL_CALLBACK for various callback functions #13

Closed lazka closed 1 year ago

lazka commented 1 year ago

_cl_icd_dispatch declares these function pointers with CL_CALLBACK which expands to __stdcall, which is not the default on 32bit Windows.

Make sure to use CL_CALLBACK in all functions assigned to it, so the right calling convention is used.

This is also motivated by clang v16 now erroring out because of this.

sthibaul commented 1 year ago

Applied, thanks! Will appear here within a day.