search

starpu-runtime / starpu

This is a mirror of https://gitlab.inria.fr/starpu/starpu where our development happens, but contributions are welcome here too!
https://starpu.gitlabpages.inria.fr/
GNU Lesser General Public License v2.1
58 stars 13 forks source link

Frontier test link failure: missing -lrocblas #51

Closed devreal closed 1 month ago

devreal commented 1 month ago

Trying to install StarPU 1.4.7 (from tarball) on Frontier. The build fails for the test binaries:

  CCLD     main/deadlock
ld.lld: error: undefined reference due to --no-allow-shlib-undefined: rocblas_initialize
>>> referenced by ../src/.libs/libstarpu-1.4.so
clang: error: linker command failed with exit code 1 (use -v to see invocation)

The command line executed is:

/bin/sh ../libtool  --tag=CC   --mode=link cc -gdwarf-2 -g3 -Wall -Werror=implicit -Werror=implicit-function-declaration -Wextra -Wunused -Wundef -Wshadow -Wpointer-arith -Wno-unused -O3 -g -O2   -o main/deadlock main/deadlock.o  -lrt -lrt  -lpthread ../src/libstarpu-1.4.la  -lpthread -lpthread -lhwloc   -L/opt/rocm-5.7.1/lib -lamdhip64  -lhipblas -lstdc++ 
libtool: link: cc -gdwarf-2 -g3 -Wall -Werror=implicit -Werror=implicit-function-declaration -Wextra -Wunused -Wundef -Wshadow -Wpointer-arith -Wno-unused -O3 -g -O2 -o main/.libs/deadlock main/deadlock.o  -lrt ../src/.libs/libstarpu-1.4.so -lpthread /usr/lib64/libhwloc.so -L/opt/rocm-5.7.1/lib -lamdhip64 -lhipblas -lstdc++ -Wl,-rpath -Wl,/usr/lib64

If I take this linker command and add -lrocblas the linking succeeds. I believe this is explicitly needed even though -lhipblas is provided.

Here is the config.log: config_frontier_1.4.7.log

sthibaul commented 1 month ago

Indeed, I have pushed a fix to master and 1.4 branches.