search

starrhorne / preamble

14 stars 4 forks source link

Fix leaked file handle #1

Closed dhilgarth closed 11 years ago

dhilgarth commented 11 years ago

The file handle opened in Preamble.load has not been closed previously. This lead to problems later when trying to delete the loaded file.

starrhorne commented 11 years ago

Thanks! I'm traveling ATM, but will merge this when I return in a few days. On Mar 3, 2013 4:55 AM, "Daniel Hilgarth" notifications@github.com wrote:

The file handle opened in Preamble.load has not been closed previously.

This lead to problems later when trying to delete the loaded file.

You can merge this Pull Request by running

git pull https://github.com/dhilgarth/preamble master

Or view, comment on, or merge it at:

https://github.com/starrhorne/preamble/pull/1 Commit Summary

  • Fix leaked file handle

File Changes

  • M lib/preamble.rbhttps://github.com/starrhorne/preamble/pull/1/files#diff-0(55)

Patch Links:

dhilgarth commented 11 years ago

@starrhorne: Nice, thanks! :)