starryalley / Anduril2

my Anduril2 fork that provides much more features
GNU General Public License v3.0
47 stars 3 forks source link

TS10 momentary 8C #23

Closed Light-Veteran closed 1 year ago

Light-Veteran commented 1 year ago

Hi! I am new here so i hope this is the right place, if not i am so sorry. This is the first time i use this app

I set floor at level 10 in smooth and doing 8C for momentary but the lvl i see is the default lvl i set memorised in ramp so not 10. In stepped mode 8C works correctly

starryalley commented 1 year ago

Thanks for the report. However I thought 8C mementary mode uses whatever level is memorised as the level? This is from momentary-mode.c:

    // light up when the button is pressed; go dark otherwise
    // button is being held
    if ((event & (B_CLICK | B_PRESS)) == (B_CLICK | B_PRESS)) {
        momentary_active = 1;
        // 0 = ramping, 1 = strobes
        if (momentary_mode == 0) {
            set_level(memorized_level);
        }
        return MISCHIEF_MANAGED;
    }

So whatever your "memorized_level" is, it will use that. Not the floor level. But I never use momentary mode to be honest. Is this a different behaviour than the stock Anduril2?

Light-Veteran commented 1 year ago

Thank you for reply. Ok I understand what happens. Its my fault and Anduril 2 works well and also in the same way with your firmware so I am stupid 😂 From off 1H is "moon lvl" and if you set 8C after 1H the momentary gives you the standard lvl you set. Viceversa if you switch on the light and ramp down to moon lvl and then set 8C the momentary give you the moon lvl. So momentary don't work as i aspected with 1H from OFF. Solved, no issues

starryalley commented 1 year ago

Thanks. This does clarify things!