starryalley / Anduril2

my Anduril2 fork that provides much more features
GNU General Public License v3.0
47 stars 3 forks source link

Feature request: Allow indicator light mix (high/low?) with candle mode #28

Closed lukestein closed 1 year ago

lukestein commented 1 year ago

My orange-indicator TS10 looks great in fireplace mode but the indicator doesn't work in default/stock candle mode. Also, the indicator is always at a low level when mixing into fireplace mode.

Feature request: On a TS10 in default/stock candle mode, have 7C toggle between indicator off, mixing indicator low, and indicator high.

Or, have 7C toggle between indicator on and off, but use low indicator level if the main LED level is below some threshold, and high indicator if above the threshold.

Happy to clarify, discuss, or ideate further!

Cf

In candle wobble style (default/stock) we can additional use 7C to toggle if we want to use aux led to assist in tint mixing (if AUX is available)

lukestein commented 1 year ago

Just realizing my suggestion may relate to this commit

(I of course agree that high indicator is too bright at low candle levels)

starryalley commented 1 year ago

That's a good idea. I have 4 TS10's with blue/orange/red/green AUX, and high is sometimes too bright, and low is always too low. So I guess on a light with indicator LED only like TS10, 7C can be re-purposed to set indicator LED to off/low/high for all wobble style (default candle, fireplace slow, fireplace fast). On a light with AUX, nothing will be changed.

lukestein commented 1 year ago

So I guess on a light with indicator LED only like TS10, 7C can be re-purposed to set indicator LED to off/low/high for all wobble style (default candle, fireplace slow, fireplace fast). On a light with AUX, nothing will be changed.

This sounds to me like a great solution. I bet I'll wind up using white+bright orange, and white+dim red.

starryalley commented 1 year ago

This is now implemented in commit 72fccd933209e6eba36bdedbe2a0b6670bdf3076. Please give it a test if you have time. Thank you for this great suggestion. anduril.wurkkos-ts10.hex.zip

Also see this section in updated README

I have tested it on my 3000k TS10 with red aux. Attached ts10 hex.

lukestein commented 1 year ago

Thanks! I just tried the new release. Seems to work nicely except what may be a small bug:

Indicator mixes into candle if we reach candle directly from on β†’ 3H

However, indicator mix doesn't work if we enter candle from other strobe modes (i.e., lightning β†’ 3C or tactical strobe β†’ 2C); in these cases we get standard white candle only

starryalley commented 1 year ago

Thanks for testing and reporting. Yes it was my error, not resetting a flag aux_led_reset when doing 2C or 3C to switch strobe modes. I've updated the latest release. Appreciated your help here :)

lukestein commented 1 year ago

Thank you! Your fix seems to have done the trick, and I haven't noticed any other issues with this updated release πŸŽ‰

starryalley commented 1 year ago

That's good to hear. I don't have much time testing all those features anyway. :P

Light-Veteran commented 1 year ago

Don't worry, we try and test for youπŸ˜‰

starryalley commented 1 year ago

Awesome thanks @Light-Veteran . sorry I haven't got to your requests. I'll get to them one by one!

Light-Veteran commented 1 year ago

Don't worry Mark! I'm in no hurry. Your changes are worth the waitπŸ˜‰