search

starryalley / Anduril2

my Anduril2 fork that provides much more features
GNU General Public License v3.0
46 stars 2 forks source link

Ramping Bug/Issue? #5

Closed BrightZin closed 1 year ago

BrightZin commented 1 year ago

I flashed the latest kr4 no fet hex on 2 e17a d4v2's and I noticed there's a fluttery type of double blink happening when smooth ramping up through mid ramp. Not sure it it was intentional or not but I don't think non fet anduril is supposed to blink mid ramp.

starryalley commented 1 year ago

Yes I noticed this as well on my D4v2 lights but I haven't got time to figure out. Might be a bug or a configuration issue. I'll let you know when I find out why. Thanks!

starryalley commented 1 year ago

Doing some quick bisecting and found the faulty commit: 1923dd27ae3be10f48dc7926dc1b647815a78071

Apparently I forgot to enable the phase sync config for KR4 (all variants). Fixed with this commit

Thanks again for brining this to my attention. I'll create a new release shortly.

BrightZin commented 1 year ago

That was quick. Thanks for your work on this. Gonna flash some more lights once when its released. That blink was really annoying me

starryalley commented 1 year ago

I agree. I haven't EDC'd my D4v2 for the past few months (I've been using my SP10 pro and TS10 lately). All my D4v2's are stationary at home so that's my excuse not to have a motivation to analyse behind that annoying blink. Thanks again for this issue or I might never get it fixed.

I've personally verified on 4 of my D4v2 currently on my desk.

Just created a new release here

BrightZin commented 1 year ago

I flashed the no fet kr4 version and the flickering during ramping is gone but now the light flickers right when I turn it on at mid ramp or higher

starryalley commented 1 year ago

Any chance it is the startup mode default being set to ramp up (mode 1)? See details: https://github.com/starryalley/Anduril2#start-up-mode

Set to mode 0 for the default Anduril2 behaviour. I prefer mode 1 so that's why I set it in this commit

BrightZin commented 1 year ago

No I just checked and I'm in mode 0. It turns on instantly but flickers the same way it used to during ramping

starryalley commented 1 year ago

Sure thanks for reporting. I'll see what's wrong there! SP10 pro doesn't seem to have it so I assume it's another missing part/config. I'll update when I find out.

starryalley commented 1 year ago

I can replicate the issue on my nofet and fet D4v2. This is clearly the phase sync issue, which results in the same flickers of the original problem like in the ramping up. But this is not the same as the previous fix. This issue actually exists before the latest release.

It is a bug in my startup mode code introduced in this commit.

Fix here.

I've attached kr4-nofet HEX. If you can give it a try and let me know. Thanks again for the report and test!

anduril.noctigon-kr4-nofet.hex.zip

BrightZin commented 1 year ago

Looks good, no more blinking on start up. Thanks

starryalley commented 1 year ago

Thanks again for the bug report and testing. I've just published another release.

Closing.