search

starryknight64 / Beer366

It's a One-A-Day Leap Year Beer Celebration
http://www.beer366.com
0 stars 0 forks source link

Cannot Add Beer With Beer Advocate Page #7

Open tnblank77 opened 9 years ago

tnblank77 commented 9 years ago

When I try to add the following beer:

Beer name: Showdown Rye IPA Brewery: Great Divide Family: All Sub-Style: Doubler IPA ABV (%): 8.3 BA Rating: 86 BA Page: http://www.beeradvocate.com/beer/profile/158/123363/

I get the following error:

Property [BA Page] of class [class beer366.Beer] with value [http://www.beeradvocate.com/beer/profile/158/123363/] does not pass custom validation

Also does not work for BA page strings "/158/123363/" and "/158/123363" which work on the old site.

starryknight64 commented 9 years ago

Both strings work on the old site because the old site doesn't recognize them as duplicates.

I'll update the error message to be more informative. I might even make that form smarter so it tells you before you even attempt to submit a duplicate.

tnblank77 commented 9 years ago

So the underlying issue was because the value I was trying to enter was a duplicate?

Or are you saying that the old site doesn't treat the differing strings as duplicates?

starryknight64 commented 9 years ago

Yes and yes.

starryknight64 commented 9 years ago

Every import I do to the 2.0 site brings to light these duplicates which I have to manually fix.

starryknight64 commented 9 years ago

I have an untested fix for it on the 1.0 site (https://github.com/cnthompson/Beer366/pull/55) but no platform to test it on (except the actual 1.0 site) so it hasn't been merged in yet.