search

starrylight99 / pe

0 stars 0 forks source link

Grouping case insensitivity #2

Open starrylight99 opened 12 months ago

starrylight99 commented 12 months ago

image.png

Group names with same lower case character but different capitalization are filtered under the same findGroup command For example, in image shown, one has group "default" while other has "Default", while they can arguably be the same group, it can also be not, as the markGroupAtd function behaves differently (marking groups are case sensitive) To reproduce, have two employees with the group names which differs by only their character's case, then filter under the group name (case insensitive)

nus-se-script commented 12 months ago

Team's Response

This is merely a matter of user preferences which has nothing to do with application logic.

Note that for findGroup operations, we do not make it case sensitive because it is likely that the user, in the hurry to find groups, may not capitalise the words correctly due to human error. Making it case insensitive improves the user experience.

However, this is not the case for markGroupAtd, which requires marking of groups to be specific. You do not want the user to mark the wrong group in the event that capitalised groups and non-capitalised groups are different. Making it the same reduces the accuracy.

Furthermore, the differences does not hinder app usage because you can figure out which user is in which group easily since you are not missing out any user (as opposed to some users being missing in the list) from the list after using findGroup.

Hence, we have decided to reject the bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: "However, this is not the case for markGroupAtd, which requires marking of groups to be specific. You do not want the user to mark the wrong group in the event that capitalised groups and non-capitalised groups are different. Making it the same reduces the accuracy."

I agree that this can be an intended feature of the application. However in this iteration, the group related commands such as markGroupAtd are not mentioned in the UG to be case-sensitive. This can cause some unintended behaviours when filtering (non-case sensitive) and then executing (case sensitive commands such as markGroupAtd). Hence i would still classify this as a bug that would inconvenience the user.