Git submodule branch shows the branch of the parent repository

sschleemilch commented 2 years ago

Bug Report

When navigating into a submodule, the branch name is still taken from the parent repository.

Current Behavior

Branch name in submodule does not reflect the branch of the submodule

Expected Behavior

Branch name should always match the repository of your current working directory.

Additional context/Screenshots

To reproduce:

mkdir test && cd test
mkdir top && cd top
git init
touch x
git add x
git commit -m "init"
cd ..
mkdir sub && cd sub
git init
touch x
git add x
git commit -m "init"
cd ..
cd top
git submodule add ../sub
cd sub
git checkout -b something
git branch

Possible Solution

Environment

Starship version:

starship 1.10.1
branch:master
commit_hash:
build_time:2022-08-15 18:28:29 +00:00
build_env:rustc 1.63.0 (4b91a6ea7 2022-08-08)

Shell type: zsh
Shell version: zsh 5.8 (x86_64-ubuntu-linux-gnu)
Shell plugin manager: None
Terminal emulator: Windows Terminal
Operating system: Windows WSL2 Ubuntu 20.04

Relevant Shell Configuration

# Lines configured by zsh-newuser-install
HISTFILE=~/.histfile
HISTSIZE=10000
SAVEHIST=3000

# Changing "ls" to "exa"
alias ls='exa -al --color=always --group-directories-first' # my preferred listing
alias la='exa -a --color=always --group-directories-first'  # all files and dirs
alias ll='exa -l --color=always --group-directories-first'  # long format
alias lt='exa -aT --color=always --group-directories-first' # tree listing
alias l.='exa -a | egrep "^\."'

eval "$(starship init zsh)"
eval "$(direnv hook zsh)"

source /home/q534774/.zsh/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh
source ~/.zsh/zsh-autosuggestions/zsh-autosuggestions.zsh

source /usr/share/doc/fzf/examples/key-bindings.zsh
source /usr/share/doc/fzf/examples/completion.zsh

Starship Configuration

Default

davidkna commented 2 years ago

Please try updating to starship 1.10.2, it should have a fix for this.

sschleemilch commented 2 years ago

Please try updating to starship 1.10.2, it should have a fix for this.

Indeed upgrading to 1.10.2 fixed that one already, Thanks @davidkna

starship / starship