search

start-again / spookyBot

🎃 A spooky Discord bot
MIT License
9 stars 12 forks source link

Add story command #42

Open tmttn opened 3 years ago

tmttn commented 3 years ago

This PR add the boo!story command. It will pull a semi-random story off reddit.com/r/scarystories and post it in the channel where the command was executed.

Time to get your storytelling going!

This is how it works: boostory

Caveats:

ALMerrill commented 3 years ago

A couple things I just wanted to mention, taking a look at this. First, we should try to get the anti-spam feature in before this, so that we don't get anyone spamming it and super filling the channel with stories. Or even if its not a per-user anti-spam, it could be a general story command anti-spam or something. Second, I saw that it adds some setup for local testing. Could we maybe make the reddit setup optional for local testing? That way if we're working on something unrelated to the story command, we can skip those steps and that command just won't work, maybe sending a message saying its not configured. Hopefully that makes sense. Basically I just want to avoid having people getting reddit stuff setup when they won't even be using the command. We can move those local testing setup instructions to their own section, saying to follow them if you're working on the story command. Happy to hear your thoughts on those!

tmttn commented 3 years ago

@ALMerrill I made the config optional. I changed the story to a DM for now. We can re-evaluate where the story is posted after #35 is implemented.

ALMerrill commented 3 years ago

Ok cool. Yeah I think it would be awesome if the stories showed up in the channel, as long as there’s a time limit before allowing it again haha. As a quick fix, you could probably just set a datetime variable whenever story is called, and then check that variable when it is called again, and if it’s been a certain amount of time, maybe a minute or something, then it goes, otherwise it DMs them and says it hasn’t been long enough. Sorry I don’t mean to take a control lol, I’m not even the maintainer. Just figured I’d share my thoughts, and spamming is on my mind

tmttn commented 3 years ago

No worries it's all for the greater good. 🗡️

I'm working on the temporary spam protection for this command.

illusi0nary commented 3 years ago

We have merge conflicts here because of the docker deployment.

Please use git rebase main or git merge main on your branch in order to make it mergeable :-)