start-angular / sb-admin-angular

[DEPRECATED] Starter template / theme for AngularJS Dashboard Apps
http://startangular.com/
Other
841 stars 431 forks source link

syntax error in app.js #52

Open jdcrecur opened 8 years ago

jdcrecur commented 8 years ago

in the loadMyDirectives line 33 of the app.js is there not a syntax error?

Each ocLazyLoad block ends with a comma until 48..

sanketsahu commented 8 years ago

Not really sure. What is the error you're getting?

jdcrecur commented 8 years ago

no error, I have just started building an admin panel with this theme.

This bit is just confusing and syntactically incorrect to the best of my knowledge:

What is being returned here from the "loadMyDirectives:function(..."

$stateProvider
      .state('dashboard', {
        url:'/dashboard',
        templateUrl: '/views/dashboard/main.html',
        resolve: {
            loadMyDirectives:function($ocLazyLoad){
                return $ocLazyLoad.load(
                {
                    name:'sbAdminApp',
                    files:[
                    '/scripts/directives/header/header.js',
                    '/scripts/directives/header/header-notification/header-notification.js',
                    '/scripts/directives/sidebar/sidebar.js',
                    '/scripts/directives/sidebar/sidebar-search/sidebar-search.js'
                    ]
                }),
                $ocLazyLoad.load(
                {
                   name:'toggle-switch',
                   files:["/bower_components/angular-toggle-switch/angular-toggle-switch.min.js",
                          "/bower_components/angular-toggle-switch/angular-toggle-switch.css"
                      ]
                }),
                $ocLazyLoad.load(
                {
                  name:'ngAnimate',
                  files:['/bower_components/angular-animate/angular-animate.js']
                })
                $ocLazyLoad.load(
                {
                  name:'ngCookies',
                  files:['/bower_components/angular-cookies/angular-cookies.js']
                })
                $ocLazyLoad.load(
                {
                  name:'ngResource',
                  files:['/bower_components/angular-resource/angular-resource.js']
                })
                $ocLazyLoad.load(
                {
                  name:'ngSanitize',
                  files:['/bower_components/angular-sanitize/angular-sanitize.js']
                })
                $ocLazyLoad.load(
                {
                  name:'ngTouch',
                  files:['/bower_components/angular-touch/angular-touch.js']
                })
            }
        }
    })
yjukaku commented 8 years ago

Please see https://github.com/start-angular/sb-admin-angular/issues/41

I addressed the same issue. I think a PR would be necessary to fix this.