search

start-jsk / jsk_apc

Other
36 stars 35 forks source link

Option to customize tote and cardboard_boxes locations #2655

Closed wkentaro closed 6 years ago

wkentaro commented 6 years ago

Thanks. I decided to remove SHELF_CONFIG_FILE argument until we really need it.

2018年8月3日(金) 17:41 Shun Hasegawa notifications@github.com:

@pazeshun requested changes on this pull request.

In jsk_arc2017_baxter/launch/setup/baxter.launch https://github.com/start-jsk/jsk_apc/pull/2655#discussion_r207478667:

@@ -8,6 +8,16 @@

  • <arg name="SHELF_CONFIG_FILE"
  • default="$(find jsk_arc2017_baxter)/config/$(arg task)/shelf_marker.yaml"

task argument is evaluated here, but baxter.launch doesn't have that argument and causes an error.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/start-jsk/jsk_apc/pull/2655#pullrequestreview-143098392, or mute the thread https://github.com/notifications/unsubscribe-auth/AEHFk21bVASDTopWOnfK0PlOufKVz56Zks5uNAyigaJpZM4VtkaY .

-- Kentaro Wada / 和田 健太郎 https://wkentaro.com http://wkentaro.com

wkentaro commented 6 years ago

Could you review this again?